code review kata with gerrit

CODE REVIEW KATA WITHGERRIT

/

© Enalean, 2013

This work is licensed under a .

Manuel Vacelet @vaceletm

Creative Commons Attribution-ShareAlike 3.0 Unported License

BIO / CONTEXTEnalean CTO & developerTuleap

WHY TO REVIEW CODE?

WHERE IT COMES FROM?Well known practice in FLOSS worldVarious strategy: patches (LKML), "pull requests", ...

GERRIT

Comes from Android projectGit onlyusers: Eclipse, QT, Mediawiki, Sony, Motorola, Google,SAP, ...

http://code.google.com/p/gerrit/

GERRIT WORKFLOW

REVIEWS DASHBOARD

ONE REVIEW

PATCH

DIFF, COMMENTS

PUSH FOR REVIEWOne commit == One reviewShape your commits (history rewriting!)

git push ssh://vaceletm@gerrit.tuleap.net:29418 HEAD:refs/for/master

COMMITS: SIZE MATTERSBeware The Big OneDifficult to grasp itTiny not better whatsoever

SHAPE YOUR COMMITS!

GOOD PRACTICESReduce the wait listDefine review rulesDamn fast Continuous Integration

ACCESS CONTROL

CONCLUSIONPowerfulHigh learning curve@Enalean: highest dev ROI this year

QUESTIONS?

CREDITSIt's all about feedback - code review as a great tool in theagile toolboxScaling Up JGitDeploying Gerrit Code Review