code reviews - developer conference 2013
Post on 08-May-2015
1.503 Views
Preview:
DESCRIPTION
TRANSCRIPT
ENTER
Code Peer Reviews
Leave your ego at the door
08.11.2013 Frank Sons – Developer Conference 2013
Who am I?
Software Quality Engineer
Doing PHP/Java/etc. for ~15 years
PHP Usergroup Hamburg
Twitter: @FrankS
Still learning
208.11.2013 Frank Sons – Developer Conference 2013
So, what‘s this about?
Introducing Reviews
Collective Coder Ownership
The right review for the right job
Beware the dragons!
308.11.2013 Frank Sons – Developer Conference 2013
A short introduction to reviews
Forget about the code for a moment…
408.11.2013 Frank Sons – Developer Conference 2013
What‘s the idea?
5
Peer review methods are employed to maintain standards, improve
performance and provide credibility.
Wikipedia: Peer review
08.11.2013 Frank Sons – Developer Conference 2013
Reviews aren‘t limited to code…
608.11.2013 Frank Sons – Developer Conference 2013
Back to code reviews…
IBM: Inspection introduced 1970s
7
Strict checklist for approval
08.11.2013 Frank Sons – Developer Conference 2013
Absolutely not agile
„That‘s not my code!“
Collective code ownership is a mindset
808.11.2013 Frank Sons – Developer Conference 2013
What about the ego?
9
“Everyone has the right and freedom to totally suck in private.”
Jeff Atwood - @codinghorror
08.11.2013 Frank Sons – Developer Conference 2013
Forget about your ego!
10
“Attempt to be awesome in public and embrace the suck!”
Jeff Atwood - @codinghorror
08.11.2013 Frank Sons – Developer Conference 2013
Reviews are knowledge sharing!
1108.11.2013 Frank Sons – Developer Conference 2013
Share within your team…
Product knowledge
Technical knowledge
Coding Standards
Transparency
1208.11.2013 Frank Sons – Developer Conference 2013
Finding the right review method
What do you want to do today?
1308.11.2013 Frank Sons – Developer Conference 2013
Just a second…
14
“Hey, you got a minute? I need some help with a small problem.”
08.11.2013 Frank Sons – Developer Conference 2013
Ad hoc
Takes only a few minutes
15
Happens anywhere
08.11.2013 Frank Sons – Developer Conference 2013
Little impact beyond problem
Talk to the duck
1608.11.2013 Frank Sons – Developer Conference 2013
Take a look please…
17
“Can you take a look at my code please? Here is the branch.”
08.11.2013 Frank Sons – Developer Conference 2013
Peer deskcheck / pass around
Can be done asynchronous
18
Great for reviewing lots of code
08.11.2013 Frank Sons – Developer Conference 2013
Most tools work this way
We are agile!
19
“Let’s do this together!”
08.11.2013 Frank Sons – Developer Conference 2013
Pair programming
Driver and Navigator
20
Rapid Iterations
08.11.2013 Frank Sons – Developer Conference 2013
Review on the fly
Let me show you…
21
“Let me show you my code.”
08.11.2013 Frank Sons – Developer Conference 2013
Walkthrough
Author explains code
Developers ask Questions
Ideal to present and educate
Risk of overlooking critical code
2208.11.2013 Frank Sons – Developer Conference 2013
Is this really understandable?
23
“Can you read and explain my code to others?”
08.11.2013 Frank Sons – Developer Conference 2013
„Code Reading“
Reader doesn‘t know code
Other devs: „Eagle Eye view“
Author answers questions
Specific code section
2408.11.2013 Frank Sons – Developer Conference 2013
Beware the dragons!
It can be tricky…
2508.11.2013 Frank Sons – Developer Conference 2013
Egoless!
26
My ego ist not tied to my “perfect” or “imperfect” work product
Jeff Atwood - @codinghorror
08.11.2013 Frank Sons – Developer Conference 2013
Avoid the dragons
Leave the egos at the door
No fingerpointing
Follow up after review
Don‘t abuse result
Lack of knowledge
2708.11.2013 Frank Sons – Developer Conference 2013
Keep this in mind
Three to seven participants
Keep it at two hours max
Involve Managers in planning
Find problems not solutions
Review coverage vs. Project size
2808.11.2013 Frank Sons – Developer Conference 2013
You will see the benefits
Code will be understandable
Knowledge is spread
Improves communication
Light house effects
2908.11.2013 Frank Sons – Developer Conference 2013
JUST DO IT!
3008.11.2013 Frank Sons – Developer Conference 2013
This helps…
3108.11.2013 Frank Sons – Developer Conference 2013
Enjoy your reviews!
Reviews can help your team
32
Reviews are all about the mindset
08.11.2013 Frank Sons – Developer Conference 2013
Don‘t fear the dragons
Feedback welcome!
frank.sons@innogames.de
Twitter: @FrankS
slideshare.net/frank_sons
Ask for a card ;-)
3308.11.2013 Frank Sons – Developer Conference 2013
Thanks!
Hope you enjoyed it!
3408.11.2013 Frank Sons – Developer Conference 2013
top related