do your commit messages suck?files.mcgeary.org/presentations/commit-messages-rockymtnruby.pdf ·...

Do Your CommitMessages Suck?

Ryan McGearyhttp://ryan.mcgeary.org

@rmm5t

Friday, September 2, 11

The Bad

Friday, September 2, 11

dfe4c3e Staging

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixes

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixed

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More staging

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c again

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops0536fc7 Again

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops0536fc7 Again8af6da0 More

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops0536fc7 Again8af6da0 More9052cb8 Again

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops0536fc7 Again8af6da0 More9052cb8 Again7587f8b Working?

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops0536fc7 Again8af6da0 More9052cb8 Again7587f8b Working?9770886 g

Bad

Friday, September 2, 11

dfe4c3e Stagingaf0a3bb More staging fixese5a524a More staging cap setup19900ba More0841841 More fixeddffb0db Again8a0f74c Updated scripts587a09c deploy script cleanup9f474bc More stagingc3f7275 Again more staging3ee25cd Read from env file0328c7c againd5e07c7 whoops0536fc7 Again8af6da0 More9052cb8 Again7587f8b Working?9770886 g

Bad

Friday, September 2, 11

More Bad

3a61755 what a hassle

Friday, September 2, 11

More Bad

3a61755 what a hassleeec60db what a stupid hassle

Friday, September 2, 11

More Bad

3a61755 what a hassleeec60db what a stupid hasslebf77372 seriously a fucking hassle

Friday, September 2, 11

More Bad

3a61755 what a hassleeec60db what a stupid hasslebf77372 seriously a fucking hassle8b48352 this is a fucking hassle

Friday, September 2, 11

More Bad

3a61755 what a hassleeec60db what a stupid hasslebf77372 seriously a fucking hassle8b48352 this is a fucking hassleeb7cdd7 wtf dude

Friday, September 2, 11

Again Bad

18c3f84 Huge commit

Friday, September 2, 11

Huge Whoops More Again Serious Hassle Bad

c1c38fc Update deploy recipe with some stuff. I dunno. it's late

Friday, September 2, 11

The Good

Friday, September 2, 11

Good

0835022 Updated basic auth prompt to reflect app name

Friday, September 2, 11

Good

0835022 Updated basic auth prompt to reflect app name

950b8de Fixed password reset for users who use the same email on multiple accounts [Fixes #11102389]

Friday, September 2, 11

More Good

3224fff Added an extra 10s while sleeping after a Twitter rate-limit error

* Twitter isn't always ready immediately after sleeping the advertised amount of time.

Friday, September 2, 11

More Good

3224fff Added an extra 10s while sleeping after a Twitter rate-limit error

* Twitter isn't always ready immediately after sleeping the advertised amount of time.

334a2c4 Fixed bug related to contact syncing [#9190663] Contacts that should have been tagged both friend and follower were having those tags toggled on each #profile_sync run.

If the contact had "follower", and profile_sync was run, then the code would set the system_tags to ["following"], blowing away the "follower" tag.

It would do the same thing vice versa for the "following" system tag.

Friday, September 2, 11

Template

Moved all static pages into a generic PagesController [Finishes #6375]

* Cleaned up the routes* Simplified static page creation

Friday, September 2, 11

Template

Moved all static pages into a generic PagesController [Finishes #6375]

* Cleaned up the routes* Simplified static page creationDETAILS

SUMMARY

Friday, September 2, 11

Template

Moved all static pages into a generic PagesController [Finishes #6375]

* Cleaned up the routes* Simplified static page creation

VERBFRAGMENT

TICKET #

WHY

Friday, September 2, 11

Verbs 184 Added 85 Fixed 76 Upped 31 Removed 24 Switched 21 Improved 20 Updated 16 Renamed

Friday, September 2, 11

Friday, September 2, 11

Ryan McGearyryan.mcgeary.org @rmm5t ryan@mcgeary.org

McGeary Consulting Group

Friday, September 2, 11